Last modified: 2009-03-28 16:41:16 UTC
Created attachment 5848 [details] Wrap "morelinkstoimage" within the div "mw-imagepage-section-linkstoimage" (diff to r47394) Please clean up the imagePage.php to have proper HTML and no more FIXME/TODO in source. I have make a few little change. My matter is to wrap "morelinkstoimage" within the div "mw-imagepage-section-linkstoimage", because it belongs to the other things in that div. I cannot help by the TODO and FIXME. I hope "user interface" is the right component. Thank you.
Created attachment 5849 [details] a diff instead a new file of ImagePage.php I have create a diff, instead of a new file with more little change then the first attachment.
Created attachment 5854 [details] new Patch with more tweaks My last try to make the HTML-Source more readable and add two divs. One for the metadata-section and one for the filehistory-section. Wrap "morelinkstoimage" into the existing div. Add ids "reupload-link" and "edit-external". Feel free to change anything or make more. Thanks.
Please resubmit without changing <tag attr=""> to <tag attr=''>. We generally use the former and changing these is useless. Also, patch does not apply, I get a mis-smatched chunks error.
Created attachment 5967 [details] new patch with using quots for atts I hope the new patch is better and can used in the way you want used it. I had not work with patch before.
Sorry, but I don't like your patch. You don't need to use always the same quote-style. You can mix them and by that save a lot escapes, which makes the code a lot more readable. Example (and that is completely fine): $wgOut->addHTML( '<div id="shared-image-desc">' . $this->mExtraDescription . "</div>\n" );
Agree with Patrick. Also, I'm still getting the mis-matched chunks error. Are you diff'ing against trunk?
Created attachment 5973 [details] new patch for HTML tweaks on ImagePage.php I have download the php-Script from http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/ImagePage.php?revision=48951&view=markup&pathrev=48957 Open with [[WinMerge]], make the change and create a unified patch and attached them I do not know it was a good idee but you can find the source on my sandbox under http://de.wikipedia.org/w/index.php?action=edit&oldid=58412452&uselang=en (diff: http://de.wikipedia.org/w/index.php?diff=58412452&oldid=58412402&uselang=en) I hope you can work with that.
Awesome. Done in r48967.