Last modified: 2013-04-22 16:14:45 UTC
Created attachment 11892 [details] PHP fatal error on Special:NoticeTemplate (2013-03-07) Editing a banner (https://meta.wikimedia.org/w/index.php?title=Special:NoticeTemplate/view&template=FDCpropreview20031 ) and clicking "Save banner" resulted in a "Wikimedia Foundation error" page with the following error message: "PHP fatal error in /usr/local/apache/common-local/php-1.21wmf11/extensions/CentralNotice/special/SpecialNoticeTemplate.php line 919: Call to a member function logBannerChange() on a non-object" Reproduced it in a second edit to the same banner. Both edits saved fine (e.g. https://meta.wikimedia.org/w/index.php?diff=prev&oldid=5304256 ).
That's the first time $bannerObj is used, so it's obviously a non-object!
Introduced by https://gerrit.wikimedia.org/r/50768, assigning to Matt Walker
Gah! I thought I fixed this... oh well; here's the patch: https://gerrit.wikimedia.org/r/52639
Pushed to cluster.