Last modified: 2011-11-18 19:44:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34476, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 32476 - MwEmbedSupport mw.isLocalDomain does no longer work
MwEmbedSupport mw.isLocalDomain does no longer work
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-11-18 14:31 UTC by Jan Gerber
Modified: 2011-11-18 19:44 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
check first if this even is an absolute url (754 bytes, patch)
2011-11-18 14:31 UTC, Jan Gerber 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Jan Gerber 2011-11-18 14:31:38 UTC 
Created attachment 9489 [details]
check first if this even is an absolute url

testing Cortado fallback failed since mw.isLocalDomain is calling mw.Uri with a relative url. This fails.
Attached patch check first if url is absolute and only uses mw.Uri to check host if it is.
Comment 1 Michael Dale 2011-11-18 19:44:16 UTC 
thanks for the patch. You can commit that changes like these directly. ( added in r103605
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links