Last modified: 2014-11-17 10:36:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38317, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36317 - make mediawiki.special.recentchanges.js reusable
make mediawiki.special.recentchanges.js reusable
Status: NEW
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.20.x
All All
: Low normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-28 09:04 UTC by Umherirrender
Modified: 2014-11-17 10:36 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Umherirrender 2012-04-28 09:04:33 UTC
mediawiki.special.recentchanges.js defines a logic to disable some checkboxes depending on the state of a namespace selector.

This logic is also needed on Special:Contributions and Special:Watchlist (when added, see bug 31704).

Having a reusable module for this makes it easy to add that the the other special pages.

Please create a module for this. I have no idea for a name of a new module or a good concept for a module design. Thanks.
Comment 1 Umherirrender 2013-02-18 20:46:43 UTC
And since today also for Special:NewPages
Comment 2 Umherirrender 2014-01-12 08:53:26 UTC
Special:Watchlist was fixed with Gerrit change #94617
Comment 3 Bartosz Dziewoński 2014-01-12 12:52:45 UTC
If the forms are rewritten to use HTMLForm, you could:

* Convert the entire namespace selector functionality into a
  HTMLFormField subclass (dropdown + 2 checkboxes), a bit like
  HTMLSelectOrOtherField.
* Then add the code from mediawiki.special.recentchanges.js to
  mediawiki.htmlform.js, which already has some form logic (e.g. for
  <select> fields enhanced with jquery.chosen).

All this, of course, would be very boring, like most refactorings. :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links