Last modified: 2014-02-12 23:55:26 UTC
Splitting from bug 30421: > $wgMFRemovableClasses (from r94784) shouldn't be present in the MediaWiki > extension. It looks like they're also in use on Wikimedia wikis. I'm not sure if that needs to be filed separately.
It appears this array defaults to empty. If things are being removed from a production site these are specified on a config level. I think from a configuration perspective this is actually useful as it gives control to mediawiki admins... what was the reason for not thinking this is useful and should be killed?
(In reply to comment #1) > It appears this array defaults to empty. If things are being removed from a > production site these are specified on a config level. > > I think from a configuration perspective this is actually useful as it gives > control to mediawiki admins... what was the reason for not thinking this is > useful and should be killed? The question is whether this configuration variable continues to be a sensible implementation of the desired behavior (hiding code that uses particular CSS classes). $wgMFRemovableClasses pre-dates the existence of MediaWiki:Mobile.css and MediaWiki:Mobile.js. Reading MaxSem's comment at bug 30421 comment 13, it seems like this configuration variable should be killed. On the other hand, having read your comments at bug 30421 comment 17, perhaps this configuration variable has legitimate uses (and simply needs better documentation). Looking at the Wikimedia Foundation's use of this variable (<https://noc.wikimedia.org/conf/InitialiseSettings.php.txt>): --- 'wmgMFRemovableClasses' => array( 'default' => array( 'table.metadata', '.metadata mbox-small', '.metadata plainlinks ambox ambox-content', '.metadata plainlinks ambox ambox-move', '.metadata plainlinks ambox ambox-style', ), ), --- Is this appropriate to set on every wiki? Would it be better to allow individual wiki administrators to specify which classes to remove (hide) instead? I'm not sure.
$wgMFRemovableClasses and Mobile.css are not mutually exclusive. Mobile.css is useful for overriding classes, while wgMFRemovableClasses will actually remove the classes from the DOM. $wgMFRemovableClasses is still useful (and is already entirely configurable per-wiki). There may be cases where it may not make sense to override css in Mobile.css and need to fully remove the class brute-force style; for instance if there is javascript that is expected to run if a certain class is present. In the long run, we want to get to a point where things like $wgMFRemovableClasses is no longer needed, but we are not there yet. Closing as 'invalid' as there's no real bug here. If there are lingering questions about the sensibility of the particular classes articulated in wmgMFRemovableClasses in the cluster configuration, that should probably be a separate conversation.
