Last modified: 2014-11-18 18:43:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50368, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48368 - VisualEditor: Implement a find/search and replace tool
VisualEditor: Implement a find/search and replace tool
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Lowest enhancement
: ---
Assigned To: Eran Roz
:
: 53326 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-12 01:17 UTC by James Forrester
Modified: 2014-11-18 18:43 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2013-05-12 01:17:15 UTC
There's a search-and-replace tool in the wikiEditor which some users might miss and would like in VisualEditor somehow.
Comment 1 Helder 2013-08-08 13:21:29 UTC
As long as it doesn't have the same performance issues which makes it unusable (bug 23510), I support this. :-)
Comment 2 Andre Klapper 2013-08-25 20:01:49 UTC
*** Bug 53326 has been marked as a duplicate of this bug. ***
Comment 3 WhatamIdoing 2013-12-08 02:13:40 UTC
This still seems to be a popular request from users at multiple Wikipedias.
Comment 4 Amir E. Aharoni 2014-03-27 12:59:49 UTC
I'd say that it's a regression and not an enhancement.
Comment 5 Amir E. Aharoni 2014-04-05 08:17:33 UTC
Somebody told me that my comment was unclear: when I say that it's a regression and not an enhancement, I mean that the *lack* of search and replace functionality is a regression, and the request to have it should be treated as a bug report and not as an enhancement request.
Comment 6 Eran Roz 2014-04-05 08:40:46 UTC
I agree with Amir. This is regression as this option is already available in WikiEditor and it is very basic functionality (available even in simple notepad), so it isn't an enhancement but at least normal (or major?) bug.

As part of the work on [[meta:Grants:IEG/Visual_editor-_gadgets_compatibility]], I plan to work on [[meta:User:Pathoschild/Scripts/Regex menu framework]], that should give a quick&dirty workaround to this issue.
Comment 7 Helder 2014-04-05 16:48:17 UTC
(In reply to Eran Roz from comment #6)
> As part of the work on
> [[meta:Grants:IEG/Visual_editor-_gadgets_compatibility]], I plan to work on
> [[meta:User:Pathoschild/Scripts/Regex menu framework]], that should give a
> quick&dirty workaround to this issue.

Consider using the new version of that script instead:
[[m:User:Pathoschild/Scripts/TemplateScript]]
Comment 8 Eran Roz 2014-05-01 17:02:48 UTC
We have a first working draft for replace tool for VE:
https://en.wikipedia.org/wiki/User:%D7%A2%D7%A8%D7%9F/veReplace.js

It works and replace the specified text, and undo&redo are properly supported (the last is just a claim that we didn't hack the VE too much :) ). 
Currently it does only "replace all" but it can be easily extended with simple replace function, regexs and more... 
We didn't "publish" it yet in village pumps since we want to do add at least some of this features before.
Comment 9 James Forrester 2014-05-01 20:14:37 UTC
(In reply to Eran Roz from comment #8)
> We have a first working draft for replace tool for VE:
> https://en.wikipedia.org/wiki/User:%D7%A2%D7%A8%D7%9F/veReplace.js

This ends up in the (mis-labelled) "Insert" menu, right? Would it be helpful it we created a category of tool to manipulate the contents (a spelling or grammar tool might also fit here, though again it's something you'd generally expect your browser to provide)?
Comment 10 Eran Roz 2014-05-23 21:13:43 UTC
Yes, I would like if it would be possible to create an extra different menu, instead of adding all the tools to mislabelled "Insert". I think the new "Language" option will also fit here.
Comment 11 James Forrester 2014-05-23 21:22:37 UTC
(In reply to Eran Roz from comment #10)
> Yes, I would like if it would be possible to create an extra different menu,
> instead of adding all the tools to mislabelled "Insert". I think the new
> "Language" option will also fit here.

Hmm. Possibly. I was thinking of putting it in the "text styling" menu, but it could live here.

Is there anything else that would live in the "Tools" menu? (Note that the obvious items to go in a "tools" menu – copy, cut, paste, paste formatting – can't be done in Javascript at all, sadly.)
Comment 12 Eran Roz 2014-05-23 21:38:17 UTC
I can only think of "Language" and "Replace", so I guess we don't have enougth tools right now for a new menu.
(or maybe the "advanced" options (page settings, categories etc...) is actually "tools" menu?)
Comment 13 James Forrester 2014-05-23 23:39:49 UTC
(In reply to Eran Roz from comment #12)
> I can only think of "Language" and "Replace", so I guess we don't have
> enougth tools right now for a new menu.
> (or maybe the "advanced" options (page settings, categories etc...) is
> actually "tools" menu?)

We've been struggling with what to do with categories (which are pretty vital) compared to "don't show TOC" (which is pretty rare). Suggestions for improvements to the toolbar are always welcome. :-)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links