Last modified: 2013-09-19 19:03:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52758, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50758 - Multiline comment followed by a space leads to the space being nowiki-escaped
Multiline comment followed by a space leads to the space being nowiki-escaped
Status: NEW
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
:
: 52266 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-04 16:54 UTC by Oliver Keyes
Modified: 2013-09-19 19:03 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Oliver Keyes 2013-07-04 16:54:05 UTC
https://en.wikipedia.org/w/index.php?title=Northrop_Loom&diff=562756829&oldid=543023104 added matching nowiki tags, but the change didn't actually include any markup - or, well, anything (it was an attempt to add a comma, which hasn't appeared).
Comment 1 Oliver Keyes 2013-07-04 17:12:15 UTC
Belay that; comma appears, I'm just blind :). Still no reason for the nowikis I can see.
Comment 2 Maggie Dennis 2013-07-04 19:06:34 UTC
Original problem occurred on Firefox on Windows 7. I didn't replicate it, but another editor did with Chrome on Windows 7: http://en.wikipedia.org/w/index.php?title=User%3AEdgepedia%2FVE%2FNL&diff=562864059&oldid=562863922
Comment 3 James Forrester 2013-07-12 14:25:05 UTC
This is reproducible; if you edit the original in VE https://en.wikipedia.org/w/index.php?title=User:Edgepedia/VE/NL&oldid=562863922&veaction=edit and make no changes it clean-diffs (selser to the rescue), but if you try to replicate the edit (add a comma anywhere in the paragraph after the "Economics" heading), the text following the multi-line HTML comment is escaped in <nowiki>s.
Comment 4 ssastry 2013-07-12 14:38:26 UTC
Simplified test case.  Run this through wt2wt in Parsoid. " bar" will be nowiki escaped, but " foo" will not be.

<!--
--> foo

x <!--
--> bar

If you parse the above wikitext (ex: paste it in enwiki sandbox) " foo" will be rendered as preformatted text but " bar" is not.  Parsoid handles that correctly.

But, the multiline comment followed by a space trips Parsoid's nowiki insertion code when converting the html to wikitext.  It doesn't realize that " bar" will not be preformatted because the the comment did not start at the beginning of the line many lines up.

We'll look into this, but I suppose this is not a very common occurrence.
Comment 5 ssastry 2013-07-30 15:57:51 UTC
*** Bug 52266 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links