Last modified: 2014-01-07 09:31:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59749, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 57749 - Optimize SiteLinkTable::saveLinksOfEntity to only update the table if actually necessary


Summary:	Optimize SiteLinkTable::saveLinksOfEntity to only update the table if actuall...

Status:	VERIFIED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	WikidataRepo (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Wikidata bugs

URL:
Whiteboard:	backlog
Keywords:	performance

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-11-29 15:26 UTC by Daniel Kinzler
Modified:	2014-01-07 09:31 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2013-11-29 15:26:15 UTC

Currently, SiteLinkTable::saveLinksOfEntity unconditionally deleted all links for the item, then adds all links for the item.

Instead, it would be nice to just delete the links that were since removed
from, and add just the ones that got added to the entity.

Comment 1 Gerrit Notification Bot 2013-12-04 20:08:15 UTC

Change 99194 had a related patch set uploaded by Daniel Kinzler:
(bug 57749) reduce churn on wb_items_per_site table.

https://gerrit.wikimedia.org/r/99194

Comment 2 Gerrit Notification Bot 2013-12-05 14:29:40 UTC

Change 99194 merged by Jeroen De Dauw:
(bug 57749) reduce churn on wb_items_per_site table.

https://gerrit.wikimedia.org/r/99194

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links