Last modified: 2014-01-03 01:34:31 UTC
Created attachment 14188 [details] mw.notify() with type for watch and patrol mw.notify() is used for success and for fail notifications. But it has always the same style. It would be nice to have a set of predefined ui styles for different types. The types should orient at the API results: For example: * type "notify": Green. Success. Default style. * type "warn": Yellow. Success but with warning. * type "error": Red. Fail. I created a patch to demonstrate the idea. The styles use different background colors for the different types. It would be better to have self-explanatory icons.
Hi! Thanks for your patch! You are welcome to use Developer access https://www.mediawiki.org/wiki/Developer_access to submit this as a Git branch directly into Gerrit: https://www.mediawiki.org/wiki/Git/Tutorial Putting your branch in Git makes it easier to review it quickly. If you don't want to set up Git/Gerrit, you can also use https://tools.wmflabs.org/gerrit-patch-uploader/ Thanks again! We appreciate your contribution.
Change 105104 had a related patch set uploaded by Gerrit Patch Uploader: mw.notify() with message type and predefined styles https://gerrit.wikimedia.org/r/105104
(Fomafix, there are some comments on the gerrit change – I'm posting here since I'm not sure if you're watching it. You should get a labs/gerrit account (aka "Developer access") to be able to get automated mail about new comments from gerrit and to reply there, even if you're using the patch uploader to submit patches :) )
