Last modified: 2014-01-27 09:04:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62193, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60193 - asset-check.py and other front end performance instrumentation needs further thought
asset-check.py and other front end performance instrumentation needs further ...
Status: PATCH_TO_REVIEW
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
wmf-deployment
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: performance
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-18 05:23 UTC by MZMcBride
Modified: 2014-01-27 09:04 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2014-01-18 05:23:04 UTC
Re: https://github.com/wikimedia/operations-puppet/blob/production/modules/webperf/files/asset-check.py

This asset-check.py script currently checks a few selected main pages and aggregates the data into Ganglia graphs, as I understand it. A better approach is probably needed here given that this aggregation makes diagnosis of issues more difficult when examining the graphs and attempting to trace what caused a particular spike.

This script also seems to import itertools needlessly and could use minor additional comments (why the reload(sys)?).

Generally, front end performance instrumentation needs some love. This will probably be the subject of future tickets.
Comment 1 Gerrit Notification Bot 2014-01-21 20:33:12 UTC
Change 108823 had a related patch set uploaded by Ori.livneh:
asset-check: report to Graphite rather than Ganglia

https://gerrit.wikimedia.org/r/108823
Comment 2 Gerrit Notification Bot 2014-01-21 20:36:30 UTC
Change 108823 merged by Ori.livneh:
asset-check: report to Graphite rather than Ganglia

https://gerrit.wikimedia.org/r/108823
Comment 3 Gerrit Notification Bot 2014-01-21 21:23:29 UTC
Change 108831 had a related patch set uploaded by Tim Landscheidt:
webperf: Remove misleading references to Ganglia

https://gerrit.wikimedia.org/r/108831
Comment 4 Gerrit Notification Bot 2014-01-27 09:04:50 UTC
Change 108831 merged by Ori.livneh:
webperf: Remove misleading references to Ganglia

https://gerrit.wikimedia.org/r/108831

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links