Last modified: 2014-09-26 22:35:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71698, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 69698 - Using "/*@noflip*/ /*@embed*/" annotation doesn't work (although other combinations do)
Using "/*@noflip*/ /*@embed*/" annotation doesn't work (although other combin...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.24rc
All All
: Normal normal (vote)
: 1.24.0 release
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-08-18 14:40 UTC by Bartosz Dziewoński
Modified: 2014-09-26 22:35 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bartosz Dziewoński 2014-08-18 14:40:09 UTC 
Using "/*@noflip*/ /*@embed*/" annotation doesn't work. All other valid combinations do, I added a test for them in Ie30bab25.
Comment 1 Bartosz Dziewoński 2014-08-18 15:41:54 UTC 
https://gerrit.wikimedia.org/r/154823
Comment 2 Gerrit Notification Bot 2014-08-29 19:45:11 UTC 
Change 154823 merged by jenkins-bot:
Make "/*@noflip*/ /*@embed*/" annotation work

https://gerrit.wikimedia.org/r/154823
Comment 3 Gerrit Notification Bot 2014-09-22 11:23:41 UTC 
Change 161754 had a related patch set uploaded by Bartosz Dziewoński:
Make "/*@noflip*/ /*@embed*/" annotation work without CSSJanus hacks

https://gerrit.wikimedia.org/r/161754
Comment 4 Gerrit Notification Bot 2014-09-23 22:57:22 UTC 
Change 161754 merged by jenkins-bot:
Make "/*@noflip*/ /*@embed*/" annotation work without CSSJanus hacks

https://gerrit.wikimedia.org/r/161754
Comment 5 Gerrit Notification Bot 2014-09-26 18:20:22 UTC 
Change 163212 had a related patch set uploaded by Krinkle:
Make "/*@noflip*/ /*@embed*/" annotation work without CSSJanus hacks

https://gerrit.wikimedia.org/r/163212
Comment 6 Gerrit Notification Bot 2014-09-26 18:27:31 UTC 
Change 163212 merged by jenkins-bot:
Make "/*@noflip*/ /*@embed*/" annotation work without CSSJanus hacks

https://gerrit.wikimedia.org/r/163212
Comment 7 Bartosz Dziewoński 2014-09-26 22:35:46 UTC 
Backported to 1.24 after all.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links