Last modified: 2014-10-23 02:31:32 UTC
Having two search submit buttons is bad for site usability. Users end up confused both what button to click and what the heck the difference between them is. This actually got us a place in a list of things NOT to do: http://www.smashingmagazine.com/2008/12/04/designing-the-holy-search-box-examples-and-best-practices/ This is basically why simplesearch was introduced in vector. For other skins however we actually have $wgUseTwoButtonsSearchForm. Which when set to false replaces the unusable "Go" + "Search" with a single "Go" button and an "Advanced search" link that links to the search page and acts as a usable replacement for the fulltext search button.
We may also want to consider making it so that the go button in the single-button form says "Search" not "Go". "Go" is a bad name for a search button.
fwiw I agree. Who decides?
(In reply to comment #2) > fwiw I agree. Who decides? The decision shall be made by those who are to blame[1] for the effect the decision will cause. [1] https://en.wikipedia.org/wiki/User:MZMcBride/Blame_wheel In all seriousness, I'd say put up a change in Gerrit and we'll see whether those who review changes will approve. In more seriousness, I approve.
For the record, these are only used by MonoBook and CologneBlue.
Change 145517 had a related patch set uploaded by Rohan013: $wgUseTwoButtonForm is set to false by default https://gerrit.wikimedia.org/r/145517
Note: This is no longer used by MonoBook and not used by Vector either. Only used by mediawiki/skins/Nostalgia. Perhaps we should subst Nostalgia's two button form and rid the varirable?
Ah, Config class made it harder to find. Looked for $?wgUseTwoButtonsSearchForm instead of UseTwoButtonsSearchForm. Both MonoBook and CologneBlue actually still use it.
Wikimedia doesn't currently override this configuration variable so changing this would affect Wikimedia wikis.
Created attachment 16342 [details] Current behaviour (UseTwoButtonsSearchForm=true)
Created attachment 16343 [details] Proposed behaviour (UseTwoButtonsSearchForm=false)
As stated, we should move away from having a "Go" button. Also, please notice that the search suggestions for Monobook are now the same as Vector, so they contain both exact matches (which "go") and a final "containing..." option (which "search"es). I suggest: 1. We rename the "Go" button search, which is more consistent with the Vector search icon button. 2. We drop the advanced search button, since we have it through the suggestions. If we must keep it, it needs to actually go to the advanced tab of the search page.
(In reply to Trevor Parscal from comment #11) > 2. We drop the advanced search button, since we have it through the > suggestions. If we must keep it, it needs to actually go to the advanced tab > of the search page. How about hiding it with JS.
Change 145517 abandoned by Krinkle: Set $wgUseTwoButtonsSearchForm false by default Reason: The bug is still under consideration. As it this, this feature would not be enabled by default. Patch can be re-opened or resubmitted later. https://gerrit.wikimedia.org/r/145517
