Last modified: 2014-11-20 15:01:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52082, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50082 - Accidental temporary transclusions can result in notification confusion
Accidental temporary transclusions can result in notification confusion
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
unspecified
All All
: Unprioritized normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
https://en.wikipedia.org/w/index.php?...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-24 02:59 UTC by MZMcBride
Modified: 2014-11-20 15:01 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2013-06-24 02:59:59 UTC
As explained at <https://en.wikipedia.org/w/index.php?title=User_talk:Newyorkbrad&oldid=561300984#Question_for_TPWs>, it goes something like this:

* editor mistakenly adds {{WP:FOO}} to a talk page;
* {{WP:FOO}} gets expanded and suddenly a bunch of users get notifications about a mention wherever {{WP:FOO}} was added;
* editor fixes syntax ({{WP:FOO}}), transclusion goes away, notifications linger causing confusion
Comment 1 spage 2013-09-23 20:44:10 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/218
Comment 2 Kunal Mehta (Legoktm) 2013-10-18 07:25:48 UTC
Not really sure if there is much that can be done, you can't take back a notification once it's been sent...
Comment 3 Mr. Stradivarius 2013-10-19 03:14:44 UTC
You could suppress notifications if the transcluded page is over a certain number of bytes, or contains more than a certain number of usernames. (I think that last one might be done already?) Getting the cut-off point right would be hard, though.
Comment 4 Scott Martin (http://enwp.org/user:scott) 2014-02-19 11:49:48 UTC
I for one would prefer transclusion not to cause notifications at all, but suspect that someone may well come up with a valid explanation of why that would be throwing the baby out with the bathwater.
Comment 5 Kunal Mehta (Legoktm) 2014-02-19 16:17:51 UTC
(In reply to Scott Martin from comment #4)
> I for one would prefer transclusion not to cause notifications at all, but
> suspect that someone may well come up with a valid explanation of why that
> would be throwing the baby out with the bathwater.

If we did that, things like {{ping}} would stop working.
Comment 6 Scott Martin (http://enwp.org/user:scott) 2014-02-20 12:59:10 UTC
See, I knew there would be a good reason. :)

There's just something about how it currently works that doesn't sit well with me - it's either ping everyone or don't substitute at all.
Comment 7 Quiddity 2014-02-24 06:18:23 UTC
The mention notification threshold was reduced from 300 to 100 in bug 48882. Could we simply lower the limit even further, to something like 10/20/30?  (Limits of 10 and 20 were suggested in 48882).
Comment 8 Quiddity 2014-10-05 07:24:34 UTC
The limit was lowered from 100 to 20, in https://gerrit.wikimedia.org/r/#/c/159804/

A few of the devs are discussing overhauling the Echo Mention system to not require a signature, but no decisions/directions yet, afaik.
Comment 9 Quiddity 2014-10-05 07:35:57 UTC
Nope. My mistake.  That fix was Flow-specific.  I've filed https://trello.com/c/cRjNZzdF/ to do the same in Echo. Sorry :/
Comment 10 Gerrit Notification Bot 2014-10-07 22:27:13 UTC
Change 159800 had a related patch set uploaded by EBernhardson:
Limit Echo mentions to 20 users

https://gerrit.wikimedia.org/r/159800
Comment 11 Gerrit Notification Bot 2014-10-27 15:40:40 UTC
Change 159800 merged by jenkins-bot:
Limit Echo mentions to 20 users

https://gerrit.wikimedia.org/r/159800
Comment 12 Andre Klapper 2014-11-20 15:01:44 UTC
All patches mentioned in this report were merged - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links