Last modified: 2014-08-04 22:03:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60234, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58234 - Echo: User should not see a notification with raw wikitext " [[User:[Nobody]|[Nobody]]]" in it.
Echo: User should not see a notification with raw wikitext " [[User:[Nobody]|...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
unspecified
All All
: High major with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 69128 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-09 20:07 UTC by Krinkle
Modified: 2014-08-04 22:03 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of problem. (24.99 KB, image/png)
2013-12-09 20:07 UTC, Krinkle
Details

Description Krinkle 2013-12-09 20:07:51 UTC
Created attachment 14038 [details]
Screenshot of problem.

On mediawiki.org I just got the following notification:


 __
| [[User:[Nobody]|[Nobody]]] thanked you for your edit
| on MediaWiki talk:Gadget-UTCLiveClock.js.
| 1 day ago | View edit
|__


Edit in question:

https://www.mediawiki.org/w/index.php?title=MediaWiki_talk:Gadget-UTCLiveClock.js&oldid=prev&diff=835266


Log:

https://www.mediawiki.org/wiki/Special:Log/thanks?page=User:Krinkle



Whatever the case, the main issue is that [Nobody] doesn't parse when used inside [[User:]] in wikitext (at least not in the parser Echo uses for this). So either it should be replaced with a placeholder, or perhaps the notification should be hidden entirely if it doesn't have sufficient data.

Either way, it should not be communicating a transaction with user=[Nobody] because that is an invalid username and also invalid page title for user pages in general. Presumably the latter is on purpose, (so that it can't point to an existing user, though we do have reserved usernames for certain purposes), but then it shouldn't try to parse it as such inside the notification.
Comment 1 Kunal Mehta (Legoktm) 2013-12-09 21:29:29 UTC
The Thanks bug which caused the broken notification has been fixed and is just awaiting deployment. 

The use of "[nobody]" when there is no user or the username has been suppressed is bad and should be fixed.
Comment 2 Krinkle 2013-12-10 19:36:10 UTC
Which commit is that?
Comment 3 Kunal Mehta (Legoktm) 2014-08-04 22:03:40 UTC
*** Bug 69128 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links