Last modified: 2014-10-03 20:18:44 UTC
1. Open VisualEditor 2. Find or create a paragraph with a link followed by some non-linked text 3. Inspect the link 4. While the link inspector is open, click to drop the cursor in the non-linked text The link inspector does not close, and instead moves to follow your selection.
This broke in https://gerrit.wikimedia.org/r/#/c/162495/ , which made it so contextChange is no longer emitted when the selection moves from inside a link to outside a link.
Related? Bug 71151.
(In reply to Bartosz Dziewoński from comment #2) > Related? Bug 71151. Yes, absolutely. While investigating this, I wished I had "git bisect concerning" in addition to "good" and "bad". At first, nothing was wrong, then the flicker started happening, and now it doesn't close at all. I think this happened because Ed changed the context to reposition itself directly from events emitted by the surface. The surface also emits a contextChange event that causes the context to realize that it should close (or did; this bug is about that event not being emitted any more), but that event listener is debounced, so we close the context after moving it.
Change 163783 had a related patch set uploaded by Catrope: Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's https://gerrit.wikimedia.org/r/163783
Change 163783 merged by jenkins-bot: Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's https://gerrit.wikimedia.org/r/163783
Change 163852 had a related patch set uploaded by Jforrester: Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's https://gerrit.wikimedia.org/r/163852
Change 163852 merged by jenkins-bot: Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's https://gerrit.wikimedia.org/r/163852
Merged into master and deployed to wmf1.
Verified the fix in test2 and production