Last modified: 2014-11-19 09:01:18 UTC
We now have ruby in the OOjs UI repo, so we should enable Rubocop and make sure we're already passing it.
I guess Zeljkof can handle it :-)
$ rubocop Inspecting 3 files WWC Offenses: ... 3 files inspected, 718 offenses detected
Change 172716 had a related patch set uploaded by Zfilipin: Prepare repository for RuboCop https://gerrit.wikimedia.org/r/172716
Change 172719 had a related patch set uploaded by Zfilipin: Fixed whitespace that RuboCop did not ignore https://gerrit.wikimedia.org/r/172719
Change 172722 had a related patch set uploaded by Zfilipin: Fixed RuboCop Style/AndOr offense https://gerrit.wikimedia.org/r/172722
Change 172726 had a related patch set uploaded by Zfilipin: Fixed RuboCop Style/AsciiComments offense https://gerrit.wikimedia.org/r/172726
Change 172730 had a related patch set uploaded by Zfilipin: Fixed RuboCop Style/EmptyLineBetweenDefs offence https://gerrit.wikimedia.org/r/172730
Change 172731 had a related patch set uploaded by Zfilipin: Fixed RuboCop Style/EmptyLines offense https://gerrit.wikimedia.org/r/172731
Change 172732 had a related patch set uploaded by Zfilipin: Fixed RuboCop Style/NegatedIf offense https://gerrit.wikimedia.org/r/172732
Change 172733 had a related patch set uploaded by Zfilipin: Fixed RuboCop Style/SignalException offense https://gerrit.wikimedia.org/r/172733
Change 172734 had a related patch set uploaded by Zfilipin: Fixed RuboCop Style/SpaceAroundEqualsInParameterDefault offense https://gerrit.wikimedia.org/r/172734
Change 172738 had a related patch set uploaded by Zfilipin: Fixed RuboCop Style/CommentIndentation offense https://gerrit.wikimedia.org/r/172738
Change 172739 had a related patch set uploaded by Zfilipin: Fixed RuboCop Style/NilComparison offense https://gerrit.wikimedia.org/r/172739
Change 172740 had a related patch set uploaded by Zfilipin: Fixed RuboCop Style/SpaceAfterComma offense https://gerrit.wikimedia.org/r/172740
Change 172741 had a related patch set uploaded by Zfilipin: Fixed RuboCop Style/TrailingBlankLines offense https://gerrit.wikimedia.org/r/172741
Change 172742 had a related patch set uploaded by Zfilipin: Fixed RuboCop Style/WordArray offense https://gerrit.wikimedia.org/r/172742
Change 172719 abandoned by Zfilipin: Fixed whitespace that RuboCop did not ignore https://gerrit.wikimedia.org/r/172719
Change 172738 abandoned by Zfilipin: Fixed RuboCop Style/CommentIndentation offense https://gerrit.wikimedia.org/r/172738
Change 173813 had a related patch set uploaded by Zfilipin: Prepare oojs/ui repository for RuboCop https://gerrit.wikimedia.org/r/173813
Change 173813 merged by jenkins-bot: Prepare oojs/ui repository for RuboCop https://gerrit.wikimedia.org/r/173813
Change 172716 merged by jenkins-bot: Prepare repository for RuboCop https://gerrit.wikimedia.org/r/172716
Change 173939 had a related patch set uploaded by Hashar: Make oojs-ui-bundle-rubocop voting https://gerrit.wikimedia.org/r/173939
Change 173939 merged by jenkins-bot: Make oojs-ui-bundle-rubocop voting https://gerrit.wikimedia.org/r/173939
Bug as filed is fixed; outstanding patches are all "make it pass without overrides".
Change 172726 merged by Hashar: Fixed RuboCop Style/AsciiComments offense https://gerrit.wikimedia.org/r/172726
Change 172730 merged by Hashar: Fixed RuboCop Style/EmptyLineBetweenDefs offence https://gerrit.wikimedia.org/r/172730
Change 172731 merged by Hashar: Fixed RuboCop Style/EmptyLines offense https://gerrit.wikimedia.org/r/172731
Change 172732 merged by Hashar: Fixed RuboCop Style/NegatedIf offense https://gerrit.wikimedia.org/r/172732
Change 172733 merged by Hashar: Fixed RuboCop Style/SignalException offense https://gerrit.wikimedia.org/r/172733
Change 172734 merged by Hashar: Fixed RuboCop Style/SpaceAroundEqualsInParameterDefault offense https://gerrit.wikimedia.org/r/172734
Change 172739 merged by Hashar: Fixed RuboCop Style/NilComparison offense https://gerrit.wikimedia.org/r/172739
Change 172740 merged by Hashar: Fixed RuboCop Style/SpaceAfterComma offense https://gerrit.wikimedia.org/r/172740
Change 172741 merged by Hashar: Fixed RuboCop Style/TrailingBlankLines offense https://gerrit.wikimedia.org/r/172741
Change 172722 merged by Hashar: Fixed RuboCop Style/AndOr offense https://gerrit.wikimedia.org/r/172722
Patches have been merged in.
Change 172742 abandoned by Zfilipin: Fixed RuboCop Style/WordArray offense https://gerrit.wikimedia.org/r/172742